Chua Chee Seng
Chua Chee Seng
@wimjongman I tried to build your prepare_for_java11 with graalvm jdk8 but unable to: ``` Caused by: java.lang.UnsupportedClassVersionError: org/eclipse/tycho/core/p2/P2ArtifactRepositoryLayout has been compiled by a more recent version of the Java Runtime...
@wimjongman By the way I built master branch in another mac laptop with adoptopenjdk 8 and it builds fine.
@mkurz I just pushed a quick commit according to your comments, do you mind to see if it is fit for merging now? Thanks!
@mkurz I have resolved the conflict and upgraded to use scalatest+selenium 3.2.12.1, which includes a new support for MS Edge browser, do you mind to review and consider merging this...
@mkurz Ping! I have resolved the conflict and this PR is ready for your review again. Thanks!
@mkurz That's a good idea, I am adding CI build in scalatest+selenium (one of the dependency here) and it seems to work: https://github.com/scalatest/scalatestplus-selenium/pull/20 But when I added the same ci.yml...
@mkurz By the way I think the current main is broken now? When I tried to build it I got the following error: ``` cheeseng@cheeseng-RAVEN:~/git/scalatestplus-play$ sbt clean test [info] welcome...
@mkurz I have added ci.yml that will run CI, here's the successfully run for this PR: https://github.com/playframework/scalatestplus-play/runs/7341113874?check_suite_focus=true Cheers.
@mkurz Ping again! I have updated the PR to use the newly released ScalaTest 3.2.13, the CI tests run that included in this PR seems to be green also: https://github.com/playframework/scalatestplus-play/runs/7604177607?check_suite_focus=true...
@mkurz Ping again! I have updated the PR to use selenium 4.4.0 and htmlunit 3.64.0, and the CI build is green.