cheerio icon indicating copy to clipboard operation
cheerio copied to clipboard

Fix potential github action smells

Open ceddy4395 opened this issue 9 months ago • 1 comments

Hey! 🙂 I've made the following changes to your workflow:

  • Avoid running CI related actions when no source code has changed
    • Running workflows which build or test certain parts of the code base without these parts being changed is useless, as nothing new will be checked or created.
  • Steps should only perform a single command
    • When one step does multiple things at once, it becomes unclear what exactly has failed during the execution of the step.
  • Avoid deploying jobs on forks
    • Deploying from a fork is usually not wanted because in that case unreviewed code by external authors will be published/deployed to main. Furthermore, forks usually don't have the correct rights to publish/deploy and will fail the workflow anyway.

I've fixed these smells in (part of) your workflows, and I'm interested in your feedback on the following changes.

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

ceddy4395 avatar May 22 '24 14:05 ceddy4395