cheerio icon indicating copy to clipboard operation
cheerio copied to clipboard

Can you make a new release.

Open 3ldar opened this issue 2 years ago • 7 comments

Hi, I am currently using cheerio 1.0.0-rc12 and it was fine until one of other libraries we use forcing us to use "moduleResolution" : "node16" or newer. ('nodenext'). When we change this setting in tsconfig we started to have this error :

node_modules/cheerio/lib/esm/static.d.ts:2:42 - error TS2307: Cannot find module '.' or its corresponding type declarations.

2 import type { CheerioAPI, Cheerio } from '.';
                                           ~~~

It is possible to fix it by setting skipLibCheck to false or manually editing the d.ts file and replace '.' with ./index.js. I can see it is already fixed in your source file. So can you please make a new release to reflect that fix?

3ldar avatar Oct 02 '22 16:10 3ldar

Also here we are waiting for the final version with ESM Module support. Any ETA?

Thanks. Diego

meriturva avatar Nov 29 '22 07:11 meriturva

It is possible to fix it by setting skipLibCheck to false

needs to be set to true

tobiasmuehl avatar Feb 27 '23 07:02 tobiasmuehl

Would really appreciate a new release. From the bit that I've used it, the library is a great step forward. But we definitely need it to work with esm

michaelfaith avatar May 18 '23 20:05 michaelfaith

I am facing the same issue working in a monorepository using TypeScript 5.1.6 and cheerio 1.0.0-rc.12. This kinda screws me up because I'm forced to use skipLibCheck even across packages that don't use cheerio or import anything from it, I am not exactly sure why.

Come on guys, it's 2023. Proper ESM support should be a thing for any library.

virtuallyunknown avatar Aug 09 '23 17:08 virtuallyunknown

I'm not sure how this "Can you make a new release." issue became the one about TypeScript NodeNext support, but it would be really great to see this supported for the next 1.0 release. Maybe a maintainer can rename this ticket, so it doesn't get overlooked? @fb55

benasher44 avatar Jan 04 '24 16:01 benasher44

@fb55 would you be open to accepting a PR for a fix?

benasher44 avatar Jan 05 '24 21:01 benasher44

Oh I see. It's because this issue was fixed already in #3251, but there hasn't been a release since then.

benasher44 avatar Jan 06 '24 21:01 benasher44

Will there be a new npm release anytime soon? Is anyone still maintaining this library?

niclimcy avatar Jul 23 '24 09:07 niclimcy

Fixed with the 1.0 release!

fb55 avatar Aug 09 '24 19:08 fb55