cheeaun
Support for Bubble timeline on Akkoma and Chuckya
Closes #601.
Still very work in progress, but wanted to share it in the meantime!
Screenshot
Not really necessary, but all pull requests look nicer with images!
Figured out how to add it to the shortcut menu, but I'm struggling to understand how to add a new input type to the shortcut settings (the "variant" option would need a <select>).
For now I've set its type to "text", and I'm having the user input the string corresponding to the chosen variant manually.
More screenshots!
This works everywhere now, and even has a proper dropdown:
I think I also stumbled upon a bug in the import of shortcuts, which I think I fixed in 369935f3e54aed61526751cf3d8b551425e36203.
CCing @TheEssem, who might (or might not) be interested in this implementation, as author of https://github.com/TheEssem/mastodon/commit/07ff6d040f0692b5f2bc40247bb2915d370a1bcd
I think I managed to fix the merge conflicts on my fork without botching anything, so I have this running on my instance. If there's anything in particular you want another pair of eyes on, let me know.
This is perhaps a dumb question, and I swear I've searched, but what's the best way to deal with merge conflicts on the default PO file at src/locals/en.po? When I first merged this branch I just manually looked for the strings in question as a way to learn how the code worked, but that's impractical. When watching the build output after merging with the current release, I saw messages from lingui extract. Should I be running npm run messages:extract on its own, should I just run a build after a merge and let the file be replaced that way before committing it to my local repo, or is there some other best practice I should be following?
"Should I be running npm run messages:extract on its own, should I just run a build after a merge and let the file be replaced that way before committing it to my local repo, or is there some other best practice I should be following?" —@donfeduardo
I think just running a build should be enough for the relevant files to be replaced, although I never really explored how the localization system works, so perhaps @cheeaun might be able to provide a better answer :)
Rebased onto 226fd6649477460f0c1fa4377def3e37a3e3c00d and reorganized commits to be atomic.
@cheeaun please have a look when you can!
@Steffo99 this has been a while 😮💨. Would be useful to see some screenshots of this working 😁
