sonar-checkstyle icon indicating copy to clipboard operation
sonar-checkstyle copied to clipboard

How to handle SQALE?

Open muhlba91 opened this issue 5 years ago • 2 comments

SonarQube seems to have deprecated SQALE:

  • http://javadocs.sonarsource.org/7.7/apidocs/deprecated-list.html
  • https://jira.sonarsource.com/browse/SQALE-277?jql=project%20%3D%20SQALE (see project name)

For now, we are using the sqale.xml file to define, although only partly, the SQALE ratings of each check. However, first, they are not defined well (and for some it might be difficult defining them) and, secondly, what would be the new SQ process for those ratings?

Furthermore, for reading this XML file we rely on the deprecated (and to be removed without replacement) class https://github.com/SonarSource/sslr-squid-bridge/blob/master/src/main/java/org/sonar/squidbridge/rules/SqaleXmlLoader.java#L42. If SQALE is still supported and need, we must ensure to have a proper implementation working on our side to be independent of this library.

Hence, check if SQALE is still mandatory - if:

  • not: remove sqale.xml and all related code
  • mandatory: copy over implementation from library, define rule and maintain them

See:

  • https://github.com/checkstyle/sonar-checkstyle/pull/216#discussion_r279843386
  • https://github.com/checkstyle/sonar-checkstyle/issues/217#issuecomment-490434067

muhlba91 avatar May 13 '19 12:05 muhlba91

note: sqale.xml contains only an example after transitioning to loading via metadata. to be investigated: do we need to set sqale still nowadays?

muhlba91 avatar Feb 14 '22 13:02 muhlba91

do we need to set sqale still nowadays?

I never understand it. Let's drop it.

romani avatar Feb 17 '22 05:02 romani