"Additional Properties..." button in CheckConfigurationPropertiesDialog opens invisible ResolvablePropertiesDialog

[Treehopper]

I first thought Eclipse is stuck in some kind of feedback loop, but using flight recorder, I realized there must be an open modal dialog. I was able to confirm with: Alt+Shift+F1 that the active shell is ResolvablePropertiesDialog [1], but as a user I still have no way to use it, other than closing it using Alt+F4.

[1] https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java

I already had this issue in the past, but currently I am reproducing it with:

• Eclipse Checkstyle: 8.44.0.202108061901
• Version: 4.12.0.RELEASE
• Build Id: 202109130635
• Java: jdk-11.0.5.10-hotspot
• Windows

[romani]

I do not understand what is problem, please share more details

[Treehopper]

@romani Sorry for the confusion. Maybe I should've emphasized in the description that the opening dialog is completely invisible, instead of just mentioning it in the title. For anybody who does not bother activating Eclipse plug-in spies or flight recorder, Eclipse appears as if crashed. There is no error in the logs indicating that something went wrong.

In the meanwhile, I've noticed that I cannot reproduce the issue on a Ubuntu Linux (though using the exact same Checkstyle plugin version). I have, however reproduced the issue on two different Eclipse instances on Windows, using different workspaces and different themes (light/dark). I've also created a new, empty configuration, to make sure it is not related to the configuration. I've also unplugged external screens, to make sure the window is not somehow opened "off screen", as sometimes applications on windows do. Let me know if there is something else I could try.

Looking at the sources briefly, it does not appear plausible that the dialog window is really invisible, but I could imagine that the window is opened with width and height set to zero. Layouting in SWT can be a nightmare, and it wouldn't be the first time I've seen something like this happening, though I cannot tell for sure just from looking at the source code, if that is what's happening here.

[Bananeweizen]

I can't reproduce this in a current version (also on Windows). The sources look good, there is an initial size set for the dialog etc. The symptoms you describe would fit to using the wrong shell as parent when opening the dialog. That means code taking "PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell()" instead of whateverWindowMyParentIs.getShell() when opening a new dialog. I have fixed that pattern in many different plugins, and that may or may not include EclipseCS.