eclipse-cs icon indicating copy to clipboard operation
eclipse-cs copied to clipboard

Update help icon in preference to use png files

Open vogella opened this issue 4 years ago • 4 comments

The current help icons of the Preference page look bad in the dark theme. I guess they are still gif files.

image

Would you accept a PR for updating the icons to png files?

vogella avatar Jul 30 '21 07:07 vogella

@vogella I can't speak for other admins, but I am willing to look at a PR to update the PNGs. Be warned that you have to support many different flavors of Eclipse as not everyone uses the same version or the same theme.

rnveach avatar Sep 01 '21 04:09 rnveach

I would use icons from latest icons set of eclipse.

@Calixte , please share your position on this

romani avatar Sep 04 '21 14:09 romani

Does anyone know if we have to ship our own icons with the plugin, or if we can use the ones from the current theme?

Calixte avatar Sep 07 '21 21:09 Calixte

I have no idea. Either is fine for me.

romani avatar Sep 08 '21 05:09 romani