eclipse-cs icon indicating copy to clipboard operation
eclipse-cs copied to clipboard

Update to Tycho 2.1.0

Open vogella opened this issue 4 years ago • 8 comments

This is the last version which compile the neon target (which is based on Java 1.6, any newer version would require to move the target platform up.

vogella avatar Jul 30 '21 06:07 vogella

Doesn't Tycho 2 require Java 11? Are you able to run mvn clean test package successfully?

Calixte avatar Jul 31 '21 21:07 Calixte

It requires Java 11 to run itself, you can still compile code with older Java versions fine. Nevertheless, 1.7.0 is the highest version that I can use to build this repo. Beyond that, the target platform resolution fails, complaining about not being able to resolve the Java 1.6 dependency of the Juno SDK. That being said, I'm also in favor to increase the target platform to a version that requires Java 8. Compatibility is nice, but still supporting an 8 years old version is really not necessary anymore.

Bananeweizen avatar Aug 03 '21 06:08 Bananeweizen

+1 for increasing the target platform to a version which requires Java 8.

vogella avatar Aug 03 '21 13:08 vogella

I am not seeing how this repo can't support anything older than Java 8. Checkstyle requires a Java 8+ runtime for some time. Older JREs won't run with it.

rnveach avatar Aug 13 '21 02:08 rnveach

I was not aware you could build eclipse-cs with JDK 7. The travis configuration would test that we could build it with 8, 11, and 13. @vogella do you want to increase the target platform as you update to Tycho 2?

Calixte avatar Aug 23 '21 15:08 Calixte

@Calixte can do, to which target release should I move the target platform to?

vogella avatar Aug 24 '21 09:08 vogella

It looks like Eclipse 4.6 Neon is the oldest one that requires Java 8. So we could do that.

Calixte avatar Aug 26 '21 22:08 Calixte

If there is no reason it can't be done, I would split the PRs between Tycho update with the change in target release.

rnveach avatar Sep 01 '21 12:09 rnveach

Contained in #353.

Bananeweizen avatar Nov 08 '22 19:11 Bananeweizen