violation message locale switchable without restart eclipse

[qxo]

This PR suitable for user who using non-english os but want to see different locale violation message

[romani]

@qxo, please share UI screenshots before and after update to clearly shows benefits.

Please fix CI failures.

[qxo]

@qxo, please share UI screenshots before and after update to clearly shows benefits.

Please fix CI failures.

after change locale to "zh" then do "Check Code with Checkstyle" again, we'll Chinese violation message without restart eclipse.

for someone like me, who want to english violation message to compare the differences between the two languages

[qxo]

@qxo, please share UI screenshots before and after update to clearly shows benefits.

Please fix CI failures.

The CI checkstyle-check have some issues:

• not follow the "CHECKSTYLE:OFF/CHECKSTYLE:ON" , ie : Messages.java:[177,3] ...
• there lots of "MagicNumber/JavadocVariable" issue, why only the PR was reported!

[INFO] --- maven-checkstyle-plugin:3.1.1:check (checkstyle-check) @ net.sf.eclipsecs.ui ---
[INFO] There are 9 errors reported by Checkstyle 8.35 with config/checkstyle_checks.xml ruleset.
[ERROR] src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java:[89,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java:[182,33] (coding) MagicNumber: '3' is a magic number.
[ERROR] src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java:[193,81] (coding) AvoidInlineConditionals: Avoid inline conditionals.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[177,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[177,3] (coding) DeclarationOrder: Variable access definition in wrong order.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[177,24] (design) VisibilityModifier: Variable 'CheckstylePreferencePage_lblLocaleLanguage' must be private and have accessor methods.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[179,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[179,3] (coding) DeclarationOrder: Variable access definition in wrong order.
[ERROR] src/net/sf/eclipsecs/ui/Messages.java:[179,24] (design) VisibilityModifier: Variable 'CheckstylePreferencePage_lblLocaleLanguages' must be private and have accessor methods.
[INFO] ------------------------------------------------------------------------

[romani]

@qxo , please resolve violations that are introduced by your patch.

We are using special Filter that is based on git patch, so only affected code is validated, if some violations are unrelated to your changes, it might be bug in such filter, we will review them separately.

All violations are valid and come from your patch, so should be resolved.

[Bananeweizen]

Rebased and tested. Unless the patch-filter has findings, the change is good to be merged.

[romani]

@Bananeweizen, please put green tick of approval to be more explicit.

[romani]

@Calixte , this PR is ready for merge.