contribution icon indicating copy to clipboard operation
contribution copied to clipboard

minor: add openjdk21 to projects file for diff report generation

Open nrmancuso opened this issue 1 year ago • 4 comments

nrmancuso avatar Dec 10 '23 20:12 nrmancuso

@nrmancuso ping. What blocks this?

rnveach avatar Jan 20 '24 17:01 rnveach

@nrmancuso ping. What blocks this?

I think this will make diff report execution take too long/too much memory. I need to reevaluate this. We should probably just replace 17 with 21, if it’s one or the other.

nrmancuso avatar Jan 20 '24 21:01 nrmancuso

Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet.

romani avatar Jan 20 '24 21:01 romani

Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet.

Agreed, they do a good job of keeping old inputs when possible, so we really shouldn’t miss anything by always using the latest version.

nrmancuso avatar Jan 20 '24 21:01 nrmancuso

@rnveach @nrmancuso @romani

I think this got missed please replace jdk17 with 21. As you said old inputs aren't removed so we won't miss it we just gain some new inputs related to the new syntax.

why do we have this huge exclude list?

mahfouz72 avatar Jul 13 '24 01:07 mahfouz72

@rnveach @nrmancuso @romani

I think this got missed please replace jdk17 with 21. As you said old inputs aren't removed so we won't miss it we just gain some new inputs related to the new syntax.

why do we have this huge exclude list?

Maybe we don't need this anymore with our new TreeWalker property :)

nrmancuso avatar Jul 13 '24 22:07 nrmancuso

Only one jdk code is required for execution, jdk17 can be removed.

romani avatar Jul 13 '24 22:07 romani

Exclude list is needed for no violation/exception runs. If we do those type of runs with those projects, then we need it.

rnveach avatar Jul 14 '24 00:07 rnveach

Closed in favor of https://github.com/checkstyle/contribution/pull/878

nrmancuso avatar Jul 17 '24 04:07 nrmancuso