contribution icon indicating copy to clipboard operation
contribution copied to clipboard
verified publisher icon checkstyle

Refactoring of diff.groovy

Open MEZk opened this issue 8 years ago • 2 comments

  1. generateDiffReport and generateCheckstyleReport now receive too many parameters. Parameters should be represented as an objects of the specific class or the methods need to be refactored so as not to have so many parameters.

MEZk avatar Feb 08 '17 20:02 MEZk

to my mind is it fine to have that much arguments for now.

Parameters should be represented as an objects

please do not over complicate the problem. All arguments could be refactored to single structure/object as wrapper.

romani avatar Feb 08 '17 22:02 romani

should be done after #213

MEZk avatar Apr 17 '17 19:04 MEZk