checkstyle icon indicating copy to clipboard operation
checkstyle copied to clipboard

config: enforce merged contribution PR for new Checks in verify-no-exception-configs

Open Mahmoud-Ayman-Saleh opened this issue 8 months ago • 2 comments

Issue #7304

Previously, the verify-no-exception-configs task in our CI script only checked if the pull request description contained a link to a contribution PR when a diff was detected between the main repository’s check configuration and the contribution repository’s files. This was insufficient because it did not verify that the referenced contribution PR was actually merged.

This commit improves the validation by:

  • Extracting the contribution PR URL from the pull request description using a regex.
  • Using the GitHub API (with READ_ONLY_TOKEN) to retrieve the contribution PR details.
  • Checking the 'merged' status of the contribution PR.

If the contribution PR link is missing or the PR is not merged, the script prints a clear error message and fails the build. This ensures that a new Check is only accepted when its corresponding changes in the contribution repository are live.

@romani waiting for your review

Mahmoud-Ayman-Saleh avatar Apr 06 '25 03:04 Mahmoud-Ayman-Saleh

put prefix in commit "Issue #7304: " instead of "config:".

romani avatar Apr 13 '25 19:04 romani

Hello 👋!

It looks like this pull request has been inactive for a while. Could you provide the requested feedback? If no response is received in the next 60 days, we will close this pull request.

🚧 This Github Action is under testing, please let us know if it is misbehaving. 🚧

github-actions[bot] avatar May 27 '25 00:05 github-actions[bot]

We lost contributor

romani avatar Jun 27 '25 01:06 romani