checkstyle icon indicating copy to clipboard operation
checkstyle copied to clipboard

Remove deprecated method DefaultConfiguration::addAtrribute from code

Open romani opened this issue 2 years ago • 3 comments

Method marked as deprecated at 8.45 release (end of july 2021) https://github.com/checkstyle/checkstyle/commit/a42a3e1733f3c7583177a3c96de65e6a2fd7671f#diff-efcf78d0957b14212cbef50a335aac82c9820f9a7956d2a57f74bddbed6edd2eR142

issue https://github.com/checkstyle/checkstyle/issues/10164

We need to find some major version update time, and remove such methods from our API. We need to recheck plugins(maven, eclipse-cs, sonar, ...... gradle, idea.....) if they need to be updated or notify/help them to upgrade.

issue is created based on conversation : https://github.com/checkstyle/checkstyle/pull/11639

romani avatar Jun 11 '22 14:06 romani

Sevntu and sonar is using addAttribute. Eclipse and maven are not.

rnveach avatar Jun 15 '22 00:06 rnveach

@muhlba91, can you help to update Sonar code base to prepare for deprecation ?

romani avatar Jun 26 '22 14:06 romani

i'll try to address this for the next release of the plugin.

muhlba91 avatar Jul 26 '22 13:07 muhlba91