checkr-ruby icon indicating copy to clipboard operation
checkr-ruby copied to clipboard

bugfix: candidate_id should be a string

Open xiaoronglv opened this issue 2 years ago • 2 comments

Problem:

Based on the documentation, the candidate_id attribute of the report model should be a string. This gem using alias method to delegate candidate_id to the candidate object, which is a json object.

it caused errors.

# How to reproduce it?
response = Checkr::Report.retrieve(report_id)
response.candidate_id

image

Changes

explicitly define the method to access the candidate_id

reference

https://docs.checkr.com/#operation/getReport

xiaoronglv avatar Aug 01 '22 06:08 xiaoronglv

Hi @akshay-8d66 , could you please help to review my code when you get the time?

xiaoronglv avatar Aug 01 '22 06:08 xiaoronglv

This makes sense to me. Could you look into the failing tests. Happy to help if it's unclear.

akshay-8d66 avatar Aug 30 '22 19:08 akshay-8d66