criu icon indicating copy to clipboard operation
criu copied to clipboard
verified publisher icon checkpoint-restore

crit: fix bytes vs str issues with unix sock names

Open nviennot opened this issue 4 years ago • 6 comments

Improve the utf8 handling for unix socket

nviennot avatar Apr 23 '21 19:04 nviennot

Codecov Report

Merging #1453 (e9291f0) into criu-dev (f1cc40c) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head e9291f0 differs from pull request most recent head 89e67f6. Consider uploading reports for the commit 89e67f6 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##           criu-dev    #1453   +/-   ##
=========================================
  Coverage     68.77%   68.78%           
=========================================
  Files           133      133           
  Lines         32319    32319           
=========================================
+ Hits          22227    22230    +3     
+ Misses        10092    10089    -3
Impacted Files Coverage Δ
criu/uffd.c 78.25% <0.00%> (-0.48%) :arrow_down:
criu/cr-dump.c 75.40% <0.00%> (+0.10%) :arrow_up:
criu/cr-restore.c 66.39% <0.00%> (+0.12%) :arrow_up:
criu/pstree.c 85.89% <0.00%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1cc40c...89e67f6. Read the comment docs.

codecov-commenter avatar Apr 23 '21 20:04 codecov-commenter

Is there a certain image that needs this fix. Would be nice to have it included in our CI. Especially with the parallel Python 2 and Python 3 support it would be good to have a test for this change.

At https://github.com/checkpoint-restore/criu/blob/criu-dev/scripts/ci/run-ci-tests.sh#L270 is a good place to add additional images to the recode test which triggered a lot of the other recent changes to the Python code.

adrianreber avatar Apr 26 '21 06:04 adrianreber

You are right, I have to revisit this. We probably would benefit from test cases as well.

nviennot avatar May 20 '21 17:05 nviennot

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jun 20 '21 00:06 github-actions[bot]

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jul 28 '21 00:07 github-actions[bot]

@nviennot Do you want to rebase this?

adrianreber avatar Nov 25 '21 10:11 adrianreber