criu icon indicating copy to clipboard operation
criu copied to clipboard

kerndat: ensure that the CRIU process is dumpable

Open nviennot opened this issue 4 years ago • 2 comments

When running the CRIU binary is secure mode (because setuid, or setcap) the kernel sets the DUMPABLE property to 0. This in turn makes /proc/self/* root owned, preventing some of the kerndat logic to function properly.

This change ensures that the CRIU process is dumpable.

nviennot avatar Apr 23 '21 19:04 nviennot

Codecov Report

Merging #1450 (1ef265f) into criu-dev (f1cc40c) will decrease coverage by 0.11%. The diff coverage is 23.58%.

:exclamation: Current head 1ef265f differs from pull request most recent head b16b1d0. Consider uploading reports for the commit b16b1d0 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##           criu-dev    #1450      +/-   ##
============================================
- Coverage     68.77%   68.65%   -0.12%     
============================================
  Files           133      133              
  Lines         32319    32404      +85     
============================================
+ Hits          22227    22248      +21     
- Misses        10092    10156      +64     
Impacted Files Coverage Δ
criu/include/util.h 100.00% <ø> (ø)
criu/lsm.c 29.62% <0.00%> (-1.34%) :arrow_down:
criu/proc_parse.c 68.46% <ø> (ø)
criu/util.c 61.84% <2.17%> (-3.74%) :arrow_down:
criu/cr-check.c 61.54% <16.66%> (-1.07%) :arrow_down:
criu/kerndat.c 57.33% <83.33%> (+0.25%) :arrow_up:
compel/src/lib/infect.c 55.27% <100.00%> (+0.35%) :arrow_up:
criu/crtools.c 61.90% <100.00%> (ø)
criu/net.c 75.25% <100.00%> (+0.06%) :arrow_up:
criu/sk-unix.c 74.22% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1cc40c...b16b1d0. Read the comment docs.

codecov-commenter avatar Apr 23 '21 20:04 codecov-commenter

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jun 27 '21 00:06 github-actions[bot]