test: test file for socket_udp-corked

[glassxer1]

Test C/R between enabling and disabling the UDP-corked option.

Signed-off-by: Rizheng Tan [email protected]

[codecov-io]

Codecov Report

Merging #1436 (d0b86e0) into criu-dev (b98bbda) will increase coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           criu-dev    #1436      +/-   ##
============================================
+ Coverage     68.80%   68.82%   +0.02%     
============================================
  Files           133      133              
  Lines         32248    32244       -4     
============================================
+ Hits          22188    22193       +5     
+ Misses        10060    10051       -9     

Impacted Files	Coverage Δ
criu/uffd.c	76.62% <0.00%> (-0.96%)	:arrow_down:
criu/cr-restore.c	66.20% <0.00%> (-0.20%)	:arrow_down:
soccr/soccr.c	79.34% <0.00%> (-0.07%)	:arrow_down:
criu/arch/x86/cpu.c	75.49% <0.00%> (+0.16%)	:arrow_up:
compel/arch/x86/src/lib/cpu.c	78.26% <0.00%> (+2.89%)	:arrow_up:
criu/arch/x86/crtools.c	69.49% <0.00%> (+4.09%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b98bbda...d0b86e0. Read the comment docs.

[adrianreber]

Please have a look at the result of the failed tests. On some distributions and/or architectures there are compile errors which need to be fixed.

[adrianreber]

If you are fixing errors which are introduced by your current pull request, you should squash the fixes in the commit that introduced the error.

The first commit should also not have the "From:" and "Subject:" line in the body of the commit.

I restarted a few failed tests to see if they finish successfully if run a second time.

[glassxer1]

It seems like git rebase and push -f will ruin the commit histroy. What is the proper way to go back to the correct commit history now?

[adrianreber]

It seems like git rebase and push -f will ruin the commit histroy. What is the proper way to go back to the correct commit history now?

Not sure what you are asking. From a PR point of view it now looks correct. What do you mean with correct commit history?

[glassxer1]

I am expecting that rebase and push should squash the above commits into just one commit history, but in this PR, it is just a forced push commit history that appends to the past commits. I am not sure if this is the right way or not.

[adrianreber]

I am expecting that rebase and push should squash the above commits into just one commit history, but in this PR, it is just a forced push commit history that appends to the past commits. I am not sure if this is the right way or not.

In this PR I currently see only 1 commit and no CI errors. So the PR is correct.

Independent of the PR a rebase does not squash commit. A rebase just adds all your commits, as is, on top of the rebase. Squashing is something you need to do manually.

[adrianreber]

From the CI point of view and from the git commit the PR looks good. The test still fails as expected, so nothing really changes.

I am not familiar with corked UDP sockets, so I cannot say anything about the actual code changes to the test.

[glassxer1]

Judging from my page the 26 tests are all passed. Do I miss something?

[rst0git]

Judging from my page the 26 tests are all passed. Do I miss something?

Although this test appears to pass, I can see in the log that the checkpoint has failed.

Error (criu/sk-inet.c:493): inet: Can't dump corked dgram socket 1c0e0f
...
Error (criu/cr-dump.c:1780): Dumping FAILED.

See this comment in do_dump_one_inet_fd.

[adrianreber]

Judging from my page the 26 tests are all passed. Do I miss something?

Although this test appears to pass, I can see in the log that the checkpoint has failed.

The test is marked as crfail. So it is expected to fail. https://github.com/checkpoint-restore/criu/blob/criu-dev/test/zdtm/static/socket_udp-corked.desc

[avagin]

pls wrap the body of the commit message at 72 characters

[glassxer1]

pls wrap the body of the commit message at 72 characters

copy.

[github-actions[bot]]

A friendly reminder that this PR had no activity for 30 days.