checkpointctl icon indicating copy to clipboard operation
checkpointctl copied to clipboard

Add integration test with podman

Open snprajwal opened this issue 2 years ago • 3 comments

Currently, we only run tests with BATS. This does not let us test changes in real world scenarios with containers. An integration test where a container is checkpointed and then the archive used for testing is much more robust and bulletproof.

snprajwal avatar Jun 12 '23 19:06 snprajwal

It might be good to have integration tests with both CRI-O and Podman.

rst0git avatar Jun 13 '23 09:06 rst0git

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

snprajwal avatar Jun 14 '23 15:06 snprajwal

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

@rst0git @adrianreber what do you think of this?

snprajwal avatar Jul 06 '23 17:07 snprajwal