checkpointctl icon indicating copy to clipboard operation
checkpointctl copied to clipboard

Add annotations for creating OCI images from checkpoint archives

Open Parthiba-Hazra opened this issue 10 months ago • 5 comments

These annotations provide metadata including the container manager, container-name, pod, namespace for creating OCI images from checkpoint archives.

Parthiba-Hazra avatar Apr 15 '24 05:04 Parthiba-Hazra

Test Results

55 tests  ±0   55 :white_check_mark: ±0   1s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 1c47bb24. ± Comparison against base commit 873b71c9.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 05:04 github-actions[bot]

@rst0git @adrianreber Let's first confirm the structure of the annotation. After that, I will add additional annotations for Podman and CRI-O.

Parthiba-Hazra avatar Apr 15 '24 05:04 Parthiba-Hazra

This feels redundant: checkpointctl.checkpoint. Let's remove one of those words. I think checkpointctl is not really necessary. Even if we said so earlier.

adrianreber avatar Apr 15 '24 06:04 adrianreber

@adrianreber How should we handle backward comparability with CRI-O and Podman? Do we want to deprecate the old annotations and provide support for them up to specified version, or to simply replace the annotations with a "breaking change".

rst0git avatar Apr 15 '24 06:04 rst0git

@adrianreber How should we handle backward comparability with CRI-O and Podman? Do we want to deprecate the old annotations and provide support for them up to specified version, or to simply replace the annotations with a "breaking change".

For CRI-O it is relatively easy as we only use one annotation. We will just handle both (for some time or forever). For Podman I would personally do the same. No need to break anything for the annotations used by Podman. For the ones not used I would just rename them.

adrianreber avatar Apr 15 '24 06:04 adrianreber

@adrianreber PTAL

rst0git avatar May 29 '24 09:05 rst0git

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.73%. Comparing base (6c3a263) to head (27b455e). Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          11       11           
  Lines        1260     1260           
=======================================
  Hits          992      992           
  Misses        201      201           
  Partials       67       67           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 04 '24 10:06 codecov-commenter

The test failure is unexpected. Seems like some project changed the minimum Go version without changing its version. Strange.

I guess we need another PR doing make vendor before we can merge this one.

adrianreber avatar Jun 04 '24 10:06 adrianreber

The test failure is unexpected. Seems like some project changed the minimum Go version without changing its version. Strange.

I guess we need another PR doing make vendor before we can merge this one.

@adrianreber I opened one here #133

Parthiba-Hazra avatar Jun 04 '24 11:06 Parthiba-Hazra

Please rebase.

adrianreber avatar Jun 05 '24 09:06 adrianreber