frames-ios icon indicating copy to clipboard operation
frames-ios copied to clipboard

Published 20 hours ago • verified publisher icon checkout

Update PhoneNumberKit to 3.8.0 - Fixes Swift 6 Builds

Open dimitryvin opened this issue 1 year ago • 4 comments

Issue

Swift 6 Builds fail

Fix

PhoneNumberKit made a release last week fixing builds in Swift 6 as per the change log here: https://github.com/marmelroy/PhoneNumberKit/releases/tag/3.8.0

This PR updates the Package.swift as well as the Package.resolved.

dimitryvin avatar Aug 13 '24 05:08 dimitryvin

@okhan-okbay-cko Would love to get this in when possible! Thank you!

dimitryvin avatar Aug 27 '24 18:08 dimitryvin

@okhan-okbay-cko Would love to get this in when possible! Thank you!

hey @dimitryvin, would it work if you use the forked repository of yours?

okhan-okbay-cko avatar Aug 28 '24 12:08 okhan-okbay-cko

@okhan-okbay-cko Would love to get this in when possible! Thank you!

hey @dimitryvin, would it work if you use the forked repository of yours?

I can definitely use the fork in meantime. Are you planning on making this update when Swift 6 + Xcode 16 are out?

dimitryvin avatar Aug 28 '24 19:08 dimitryvin

hey @dimitryvin, thanks for confirming that targeting a forked repository will work for you in this case.

We're not planning any releases soon.

okhan-okbay-cko avatar Aug 29 '24 09:08 okhan-okbay-cko

hey @dimitryvin, apologies for getting back to you this late 🙏

Do you still get this issue with the non-beta versions of Xcode 16?

okhan-okbay-cko avatar Feb 04 '25 17:02 okhan-okbay-cko

Closing this issue as it was specific to Xcode 16b5 which is the 5th BETA version. And the underlying issue was resolved by Apple in the 6th BETA version.

I also couldn't reproduce the issue on any further Xcode versions.

Please feel free to re-open the issue or alert us if the problem is still ongoing so we can include this change in a release plan.

okhan-okbay-cko avatar Feb 05 '25 12:02 okhan-okbay-cko