marble icon indicating copy to clipboard operation
marble copied to clipboard

Refactor: Move sensitive config to private file, improve ECS deployment & healthchecks

Open nickykln opened this issue 7 months ago • 4 comments

Description

This pull request moves all sensitive configuration data (Firebase, Sentry, keys, etc.) into a private, non-versioned file environments.private.json, and updates the AWS Terraform infrastructure to dynamically load these secrets. It also improves ECS deployment robustness (healthcheck management, etc.).

Changes

  • Moved sensitive configuration to environments.private.json
  • Loads environment variables via jsondecode(file(...)) in Terraform
  • Added a .gitignore to protect sensitive files
  • Increased ALB healthcheck timeouts to avoid interruptions during long migrations
  • Fixed environment variables for CORS (MARBLE_APP_URL and MARBLE_BACKOFFICE_HOST now use the full URL)
  • Updated the README to document the new organization

Additional Information

  • Sensitive files in config/ are excluded from version control.

To test:

  • Ensure Terraform deployment runs without errors
  • Check that the application starts and endpoints are accessible

Screenshots

Not applicable for this configuration/infra PR.

Checklist

  • [x] Tests passed
  • [x] Manual QA done
  • [x] Documentation updated

nickykln avatar May 22 '25 16:05 nickykln

Hi @nickykln , Sorry I missed this PR 3 weeks ago. I'll check it out tomorrow.

Pascal-Delange avatar Jun 09 '25 18:06 Pascal-Delange

Hi @nickykln ! Thanks for the contribution. Can I please send you our contributor license agreement before we merge this ? What email address can I send it to ? Best, Pascao

Pascal-Delange avatar Jun 30 '25 14:06 Pascal-Delange

Hi @Pascal-Delange You can send it to [email protected].

nickykln avatar Aug 06 '25 07:08 nickykln

Thanks, I sent the invite to you via yousign !

Pascal-Delange avatar Sep 30 '25 14:09 Pascal-Delange