checkedc-fork icon indicating copy to clipboard operation
checkedc-fork copied to clipboard

Published 20 hours ago • verified publisher icon checkedc

Fixed for MacOS

Open aaronjeline opened this issue 4 years ago • 2 comments

Mac OS sets macros for string functions and has _FORTIFY_SOURCE set to 2.

aaronjeline avatar Jan 29 '21 18:01 aaronjeline

Hi @aaronjeline, thank you for your work on this and for submitting this PR. It will be great if the following review comments are addressed:

  1. The comments on lines 54 thro' 61 need to be updated stating why the definitions are necessary in the macOS environment in spite of FORTIFY_SOURCE being greater than 0.
  2. The fix should be applicable only in the macOS environment when FORTIFY_SOURCE == 2. It should not change definitions in non-macOS environments when FORTIFY_SOURCE ==2.
  3. The same fix is also applicable to some definitions in stdio_checked.h.

sulekhark avatar Jan 30 '21 00:01 sulekhark

@aaronjeline, thanks for the changes! Could you address the pull request feedback so that we can commit this?

dtarditi avatar Mar 24 '21 04:03 dtarditi