Eugene Kabanov

Results 98 comments of Eugene Kabanov

Everything depends on compilation options: #### Linux **nim c testtime.nim** ``` -rw-r--r-- 1 cheatfate cheatfate 176409 Jan 30 09:01 @m..@[email protected] -rw-r--r-- 1 cheatfate cheatfate 94800 Jan 30 09:01 @m..@[email protected] ```...

In `@m..@svendor@snim-chronos@[email protected]` i see a lot of ``` #line 134 "I:\\Projects\\nim-beacon-chain\\vendor\\nim-chronos\\chronos\\asyncfutures2.nim" nimln_(134, "I:\\Projects\\nim-beacon-chain\\vendor\\nim-chronos\\chronos\\asyncfutures2.nim"); ``` This lines are present for every possible line of code. The presence of ``nimln_`` in code...

I understand that you need something to work, but explanation is also needs to be more comprehensive. Because currently i dont see any reasons to accept your PR, because it...

Why we need such primitive? And why not use: ```nim proc runWithTimeInterval(time: Duration, callback: AnyOtherCallbackType): Future[void] = while true: await sleepAsync(time) if not callback(): break proc someProc() {.async.} = asyncCheck...

One more thing, your code is using already deprecated primitives.

@dryajov you can check my code example how to schedule code to be running in future. ```nim await sleepAsync(someTime) # schedule your code here ``` or if you need to...

`python.asyncio` do not have interval functions as part of core library. `boost.asio` do not have interval functions as part of core library. Why `chronos` should have such primitives?

Now the only thing which is left is marshalling/unmarshalling of GC objects through channels. Cc @zah.

Sorry but proposed algorithm not satisfies `AsyncChannel[T]` requirement to have both limited/infinite queue size.

This approach is incorrect and unsafe, there many issues present. 1. Because you are adding callback to `chronosInternalRetFuture` it is possible that you will be called not first, but last...