fretboarder icon indicating copy to clipboard operation
fretboarder copied to clipboard

accidental notes

Open sugizo opened this issue 3 years ago • 0 comments

Description

note name in ./src/modules/music.js seems not standard for one note and the others (one note use flat (â™­) and the rest use sharp (#) ) e.g.

	'Bb': 'Bâ™­',
	'C#': 'C♯',
	'D#': 'D♯',
	'F#': 'F♯',
	'G#': 'G♯',

as a result, it also can't define tuning with A# tone in ./src/modules/music.js

better to make it standard, use all flat or all sharp and then have a button to make change for accidental sign some users's behaviour read conveniently with flat, some conveniently read with sharp

Implementation details

A#
C#
D#
F#
G#

when user click button it will change into

Bb
Db
Eb
Gb
Ab

or vice versa, thanks

sugizo avatar Sep 15 '20 22:09 sugizo