Florent

Results 34 comments of Florent

> I think our v shortcut only applies to the conversation tab No, it also works on the "Files" tab (as it should, imo).

How about changing the last dialog text to ```diff -No features were enabled on this page. Try disabling Refined GitHub to see if it belongs to it at all. +No...

+1 but: ```diff -that can't be disabled +that can (only) be disabled via the "Custom CSS" field on the options page ```

This might be dangerously close to a feature setting, but how about adding a button to close the banner and remember that choice on a repo-by-repo basis? It might need...

- [x] Clean up and rewrite `SearchQuery` so its side-effects are more contained > SearchQuery is a mess, sorry about that. We try to parse, clean and update elements on...

Maybe add the "user can merge this PR" check used in `wait-for-checks` to more PR merging features, like `sync-pr-commit-title`: https://github.com/refined-github/refined-github/blob/9690ceb6430bb239ab71207ffa00fb9bee4f0fc1/source/features/wait-for-checks.tsx#L190-L191

> @cheap-glitch did you change anything there recently? Don't think so. Maybe it was https://togithub.com/refined-github/refined-github/pull/5587?

I'm still on `v22.5.22.` and it works for me Edit: Actually it also seems to work on `22.6.24` :thinking:

> > * Just for record: [Toggle for Github Theme #3802 (comment)](https://github.com/refined-github/refined-github/issues/3802#issuecomment-966471452) > > ? It's possible to run "commands" with the `>` prefix, like changing the current theme.

As a temporary "fix", you can use `yes | trash-empty` to bypass the prompt. (Of course, this doesn't solve the underlying issue.)