manticore icon indicating copy to clipboard operation
manticore copied to clipboard

Upgrade httpclient to 5.x

Open jsvd opened this issue 5 years ago • 4 comments

It seems that new fixes and enhancements are no longer added to httpclient 4.x so it may be time to adopt 5.x in this project as well.

An example of the need for this is support of 308 redirects, which has only been added to 5.0.x https://github.com/apache/httpcomponents-client/commit/2b6f7e5/

jsvd avatar Oct 30 '20 13:10 jsvd

Are the artifacts available somewhere? Maven is only showing 4.x.

https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient

Edit: Nevermind, found them at a new namespace: https://mvnrepository.com/artifact/org.apache.httpcomponents.client5

Will probably be a bit of work to upgrade, since a bunch of imports will have changed.

cheald avatar Oct 30 '20 19:10 cheald

I don’t know why the major version was included in the name (perhaps to facilitate the coexistence of 4.x and 5.x?), but here it is:

https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5/5.0.3

On Fri, 30 Oct 2020 at 19:00, Chris Heald [email protected] wrote:

Are the artifacts available somewhere? Maven is only showing 4.x.

https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cheald/manticore/issues/89#issuecomment-719739243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHYQP3TYLK6OREHPSIQR3SNMEMLANCNFSM4TE72LJA .

jsvd avatar Oct 30 '20 19:10 jsvd

It is also recommended to update due to vulnerabilities https://nvd.nist.gov/vuln/detail/CVE-2020-13956

spinenkoia avatar May 20 '21 07:05 spinenkoia

I started in on this at one point, but there were deprecations, primarily around HttpEntity, that I never finished resolving. A pull request would be very welcome here.

cheald avatar May 26 '21 18:05 cheald