kodiak icon indicating copy to clipboard operation
kodiak copied to clipboard

health_check_interval is set to True, not number of seconds

Open androa opened this issue 2 years ago • 1 comments

The documentation of redis-py says health_check_interval is an int for the number of seconds between health checks or ping/pong.

https://github.com/chdsbd/kodiak/blob/729e64dbc1211117a1d83aaccc0bcbd0967e550a/bot/kodiak/redis_client.py#L22

I assume setting it to true would be the same as setting it to 1? Maybe 10, 30, or a configurable value would be better?

androa avatar Dec 19 '23 08:12 androa

I'm open to PRs supporting configuration for this setting.

For what it's worth, this health check interval works in production, even if it is a little too frequent

chdsbd avatar Jan 12 '24 04:01 chdsbd