Christopher Dignam
Christopher Dignam
Calling `validate constraint` in a transaction defeats the purpose of using `not valid` ```sql begin; ALTER TABLE "email" ADD CONSTRAINT "fk_user" FOREIGN KEY ("user_id") REFERENCES "user" ("id") NOT VALID; ALTER...
Related to #116 We could accept an input file that would include table name, row count, index size, table size, etc. and use that information to display more useful error...
As mentioned in the [`adding-foreign-key-constraint`](https://squawkhq.com/docs/adding-foreign-key-constraint/) rule, adding a foreign key like the following will lock both tables. ```sql ALTER TABLE "email" ADD CONSTRAINT "fk_user" FOREIGN KEY ("user_id") REFERENCES "user" ("id");...
I believe a full table scan is not required for adding a new field, with a default, on PG >10: https://github.com/sbdchd/squawk/blob/6fecfd14ebca553ea6582ec55445a5eb0ceba09a/docs/docs/adding-not-nullable-field.md#adding-a-non-nullable-column
The GitHub comment can be overwhelming. Similar to #116, we should try to make it more friendly to those not familiar with Postgres migrations.
A slow update or select could leave a migration holding a transaction for longer than necessary. Changes should be broken into pieces.
Objects could be compressed locally using gzip and then the `Content-Encoding` header could be set so the file is served correctly. related: #42
### Terraform Version ``` Terraform v0.11.11 ``` ### Heroku Provider Version ``` provider.heroku v1.4.0 ``` ### Affected Resource(s) - heroku_addon.postgres-db ### Terraform Configuration Files ```hcl resource "heroku_addon" "postgres-db" { app...
Fixes GH-965 Calling `sys.argv` should run the same program as the currently running program. To make calling Poetry scripts through RunCommand match this behavior, we must set `sys.argv[0]` to be...
I'm not sure, but I think it might be a good idea to escape new line characters. This way new lines in messages don't break the output formatting in console....