epubinfo icon indicating copy to clipboard operation
epubinfo copied to clipboard

Cover parsing fails since Nokogiri 1.6.4

Open fgi opened this issue 10 years ago • 1 comments

Nokogiri 1.6.4 / 2014-11-04 release announcement mentions this fix:

  • Fix a bug with CSS attribute selector without any prefix where "foo [bar]" was treated as "foo[bar]". (#1174)

Since this fix, cover parsing fails in /models/cover.rb. Spaces should be removed in CSS attribute selectors in epub_cover_item method (lines 78 and 82 to 85). Ex: manifest.css("item [id = \"#{cover_id}\"]") should become manifest.css("item[id = \"#{cover_id}\"]")

I did not see any other impact of this Nokogiri fix in epubinfo. Thanks.

fgi avatar Dec 10 '14 16:12 fgi

Same problem

korrs avatar Mar 19 '19 10:03 korrs