chatwoot Fix: fixes GCP Redis managed don't support redis client setname command

If using Redis on GCP, actioncable will attend to use the redis client setname command. However such command is not supported. There is no way to change that behavior in cable.yml, so this alternative solution works as proposed here : https://github.com/rails/rails/issues/38244#issuecomment-575454444

Apr 08 '22 09:04 mjattiot

@sojan-official Can you please check this PR and suggest the next steps?

Apr 27 '22 05:04 pranavrajs

@mjattiot thanks a lot for the changes. let me learn about the impact of this change on existing installations and come back. If there is no further concerns, will get this merged.

May 09 '22 09:05 sojan-official

ref: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75173

Aug 03 '22 15:08 sojan-official

@sojan-official sorry I didnt get your message. We are using this patch in a chatwoot production installation and everything is working fine.

Oct 11 '22 15:10 mjattiot

@mjattiot since I didn't have a chance to evaluate the full impact of disabling id for action cable. I went with the route of adding an environment variable which can be used to control this behaviour REDIS_DISABLE_CLIENT_COMMAND

Otherwise, I have tested the changes using the GCP memory store, and everything seems to be working.

Nov 03 '22 01:11 sojan-official

Cool thx !

Nov 03 '22 09:11 mjattiot

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Dec 03 '22 10:12 github-actions[bot]