charts icon indicating copy to clipboard operation
charts copied to clipboard

Feature: opportunity to set TLS easily by default with ca-certs autogeneration if needed

Open YarikRevich opened this issue 2 years ago • 10 comments

This PR partly solves issue(#69). It addes opportunity to easily set TLS settings using values.yaml file by default.

YarikRevich avatar Jul 26 '22 10:07 YarikRevich

@YarikRevich Thank you for the PR. Is this in a state where we can test this out?

vishnu-narayanan avatar Aug 02 '22 12:08 vishnu-narayanan

@YarikRevich are you still working on this?

vishnu-narayanan avatar Aug 09 '22 11:08 vishnu-narayanan

Yes, I'm still working on this.

YarikRevich avatar Aug 09 '22 19:08 YarikRevich

@vishnu-narayanan Please, test my PR out

YarikRevich avatar Aug 10 '22 12:08 YarikRevich

@YarikRevich Could you please share instructions on how I can test this out?

vishnu-narayanan avatar Aug 10 '22 12:08 vishnu-narayanan

@vishnu-narayanan Sure, test is devidid into two parts. Before all use should set "ingress.enabled" to "true" in values.yaml. 1.(Test TLS with own certificates) Uncomment rows from 76 to 81 and then put to "ingress.tls[0].key" your own key and to "ingress.tls[0].crt" your own crt. Then run "helm install . --timeout 30m" being in charts directory. Afterwards, you'll be able to access resource with "https://chart-example.local/" 2.(Test TLS with certificate autogeneration) Uncomment rows from 76 to 81 and then delete "ingress.tls[0].key" and "ingress.tls[0].crt" items. If though one of them is not present, autogeneration will be used. Afterwards, you'll be able to access resource with "https://chart-example.local/" and you can check, that TLS certificate is generated by Kubernetes certificate generator

YarikRevich avatar Aug 10 '22 13:08 YarikRevich

@YarikRevich I am not able to test this.

  1. Are you expecting an ingress-controller to be present?
  2. At which point is the user expected to point DNS?

vishnu-narayanan avatar Aug 11 '22 14:08 vishnu-narayanan

@vishnu-narayanan User should specify DNS name via values.yaml

https://github.com/chatwoot/charts/blob/b5328fbe03ba6f9010def98a22789c0cd7a09d5d/charts/chatwoot/values.yaml#L63-L81

YarikRevich avatar Aug 11 '22 16:08 YarikRevich

@vishnu-narayanan can we look into the next steps for this PR ?

sojan-official avatar Oct 11 '22 05:10 sojan-official

@YarikRevich Sorry for the delay here. This got left behind due to other priorites. Will pick this up once the team has enough bandwidth.

vishnu-narayanan avatar Feb 21 '23 12:02 vishnu-narayanan