core fix: remove now redundant "used_account_settings" and "entered_account_settings" from `Context.get

follow up to https://github.com/chatmail/core/pull/7583

Dec 09 '25 13:12 Simon-Laux

I'm not sure if we can also remove entered_account_settings. the old configure method still seems to exist (set_config then call configure) and atleast bots are not migrated to the new add transport API yet: https://github.com/deltachat-bot/echo/issues/85

Dec 09 '25 14:12 Simon-Laux

i think, already now entered_account_settings can be removed from the info.

even if bots are using setConfig/configure, this will end up in a used_transport_settings, and that is what counts

Dec 09 '25 14:12 r10s

python tests still use some of those properties, so this needs another iteration, converting to draft until it is mergable

Dec 09 '25 17:12 Simon-Laux

entered_account_settings is sometimes useful, to detect if user has entered the port manually and this results in not using autoconfig.

Dec 13 '25 12:12 link2xt

you can not add relays/transports with invalid configuration. So I think it would be sufficient if the entered & used login params would be just logged to the log on configuration failure.

Dec 13 '25 16:12 Simon-Laux

but entered_transport_settings are useful IMO

So I think it would be sufficient if the entered & used login params would be just logged to the log on configuration failure.

made a pr: https://github.com/chatmail/core/pull/7610

Dec 13 '25 21:12 Simon-Laux

fix: remove now redundant "used_account_settings" and "entered_account_settings" from `Context.get_info()`