Core may get confused about group title and who changed it
It seems like under some circumstances the core may get confused about group title and who changed it. I just got this, except 1. I didn't change it, it was somebody else, 2. clearly the change wasn't actually accepted but yet it shows as if it happened:
- Operating System (Linux/Mac/Windows/iOS/Android): Linux
- Core Version: 2.22.0 (git: flathub)
- Client Version: desktop 2.22.0 (git: flathub)
Expected behavior
Group name changes are attributed to the correct person and only shown if they are considered to be effective.
Actual behavior
Group name changes may apparently show wrong initiator and may show in the log even though the group title change wasn't accepted.
Steps to reproduce the problem
- Not sure, the affected group is a mess
Screenshots
see above
Logs
This is literally what the message says inside when I look in Thunderbird:
Same for "You changed the group image.".
So it is not rewritten by the core for some reason. The message is actually sent by Ben and for me it displays "... by Ben", e.g. "Group image changed by Ben" in the same group.
We also need to check that the message sent by recent core at least says "I changed the group image." inside of the message.
We might add some logic to core that makes sure that system messages always get a better_msg, though I'm not sure how exactly that might make sense.