core icon indicating copy to clipboard operation
core copied to clipboard

chore: update deltachat-jsonrpc JS dependencies

Open link2xt opened this issue 2 years ago • 2 comments

link2xt avatar Nov 13 '23 14:11 link2xt

I get these typescript errors when running npm run build locally:

> @deltachat/[email protected] build:tsc
> tsc

node_modules/@types/node/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:2335:13
    2335 declare var AbortSignal: {
                     ~~~~~~~~~~~
    'AbortSignal' was also declared here.

node_modules/@types/ws/index.d.ts:321:18 - error TS2315: Type 'Server' is not generic.

321         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                     ~~~~~~~~~~~~~

node_modules/@types/ws/index.d.ts:321:34 - error TS2315: Type 'Server' is not generic.

321         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                                     ~~~~~~~~~~~~~~


Found 3 errors in 2 files.

Errors  Files
     1  node_modules/@types/node/globals.d.ts:72
     2  node_modules/@types/ws/index.d.ts:321
ERROR: "build:tsc" exited with 2.

maybe we should not update typescript? or depend on a specific version of @types/node?

Simon-Laux avatar Nov 15 '23 05:11 Simon-Laux

@Simon-Laux

Did you run npm i before running npm run build? For me npm run build executes fine.

maybe we should not update typescript?

Why?

or depend on a specific version of @types/node?

Which version, what is the problem with the version @types/ws depends on? For me it is in the output npm ls -a:

├─┬ @types/[email protected]
│ └─┬ @types/[email protected]
│   └── [email protected]

link2xt avatar Nov 16 '23 02:11 link2xt