core icon indicating copy to clipboard operation
core copied to clipboard

imex: make it possible to cancel backup export

Open link2xt opened this issue 3 years ago • 3 comments

Previously shall_stop_ongoing() was never used in backup export, so cancelling backup export did not actually stop the process.

link2xt avatar Aug 14 '22 20:08 link2xt

maybe mention it in changelog that UI's actually make use of it. So it wasn't properly canceled before?

Simon-Laux avatar Aug 17 '22 16:08 Simon-Laux

Sorry, there is a "cancel.recv()" racing against the ongoing process and cancelling it. This should be removed for more clean shutdown.

Currently cancelling works, but it simply cancels the future without using shall_stop_ongoing() and exiting cleanly.

link2xt avatar Aug 17 '22 16:08 link2xt

Is this so un-clean today, then? Cleaning up the temporary files should work already, because of the DeleteOnDrop. And using shall_stop_ongoing means cancelling has to wait until the current file is written, which could take some time if it's a big file (didn't test if anything is all of this working, though).

Hocuri avatar Aug 20 '22 10:08 Hocuri

There is no bug, actually, so closing this. More clean cancelling would be nice, but has not been a problem so far.

link2xt avatar Dec 04 '22 19:12 link2xt