core icon indicating copy to clipboard operation
core copied to clipboard
Published 4 days ago • verified publisher icon chatmail

python: don't raise an error if addr changes

Open missytake opened this issue 3 years ago • 5 comments

closes #3529

...actually, I'm not sure if it is this easy. Maybe we should add some more tests if the AEAP change goes fine. What would be proper test cases?

missytake avatar Jul 30 '22 18:07 missytake

Maybe we should add some more tests if the AEAP change goes fine. What would be proper test cases?

There already are Rust tests, so that's not that important; a simple test would be

  • Alice and Bob introduce each other
  • Alice changes her addr
  • A sends a msg to B
  • Check that B did the transition.

but again, not sure if it's necessary.

However, CI is failing; from a quick look I didn't understand why, but I can dig deeper into it if necessary.

Hocuri avatar Aug 02 '22 16:08 Hocuri

I think it's a mailadm problem - the error message is typical for mailadm. We recently introduced better error messages for that, this looks like the old error messages... I rebased it on top of master, maybe https://github.com/deltachat/deltachat-core-rust/pull/3474 is now in this branch, and we get a different error (or none).

missytake avatar Aug 03 '22 07:08 missytake

Ah, nginx was giving us a 502 for the mailadm request - I had a configuration error in my mailadm setup. Now it works.

missytake avatar Aug 03 '22 08:08 missytake 

assert msg_in_2.get_sender_contact().id is contact_of_1.id

this line fails in the new test

Hocuri avatar Aug 12 '22 15:08 Hocuri 

assert msg_in_2.get_sender_contact().id is contact_of_1.id

this line fails in the new test

yes - this is unexpected, right? the core should treat the old email address and the new email address as the same contact or not? So does this mean the python bindings lose this? The contacts somehow have different ids.

missytake avatar Aug 12 '22 15:08 missytake

the core should treat the old email address and the new email address as the same contact or not?

No. The contacts are not unified, transitioning only means that the address is replaced in all verified group chats (and in broadcast lists, if the contact was verified).

Hocuri avatar Aug 13 '22 10:08 Hocuri

This makes an awful lot of sense.

missytake avatar Aug 14 '22 09:08 missytake

any idea what's wrong with clippy? https://github.com/deltachat/deltachat-core-rust/pull/3530/checks?check_run_id=7827685498

missytake avatar Aug 14 '22 16:08 missytake

Clippy is broken also on master, after https://github.com/deltachat/deltachat-core-rust/pull/3551 is merged you can just rebase and it willl work again

Hocuri avatar Aug 14 '22 17:08 Hocuri