chatmail
Move deltachat-node repository into node/ sub directory?!
Ease synchronization of core and node developments much as happens with the python/bot bindings as well already.
It would mean we only need two repositories needed for building a desktop. Probably prebuild node binaries can then come then with each master merge. As @link2xt noted we can keep the whole history with git-subtree.
What do you think? Agreements or objections?
Not really sure if this solves an actual problem we currently have. node takes some time to adapt to newer core api but I don't feel this is an actual problem. Also the work wouldn't be less doing it in one repo I think? What makes more sense in my opinion is to move the command api to the rust repo, instead of moving things around that currently work.
I actually plan to move the cmd-api to the core repo soon, currently there are a few todo's left there, like upgrading the core version and integrating/merging @Frando's improvements.
I think we could move node to the core repo, though as jikstra said makes only sense if others are willing to adjust it too when introducing breaking api changes. also the remaining issues/prs should be transferred/solved/merged if we do it.
also regarding prebuilds of core: https://github.com/deltachat/deltachat-core-rust/issues/3107
On Sun, Apr 17, 2022 at 15:21 -0700, Simon Laux wrote:
I actually plan to move the cmd-api to the core repo soon, currently there are a few todo's left there, like upgrading the core version and integrating/merging @Frando's improvements.
Do you bring cmd-api up because you want it to make node-bindings superflous and so the node bindings wouldn't need to be moved?
I think we could move node to the core repo, though as jikstra said makes only sense if others are willing to adjust it too when introducing breaking api changes.
One idea for the merge is to notice issues earlier and also to reduce the layering complexity. That bindings need to be fixed if core changes (rare enough currently) is true in any case.
also the remaining issues/prs should be transferred/solved/merged if we do it.
I see two PRs on https://github.com/deltachat/deltachat-node/pulls but i don't see how they need to be blocking the move. Overall, the real work is porting the CI things, updating the README's.
Do you bring cmd-api up because you want it to make node-bindings superflous and so the node bindings wouldn't need to be moved?
the cmd api is not ready that fast I guess, also the nodebindings are useful for web-based bots so I don't think they will die that soon. Current plan is to expose parts of the cmd-api (basically the thing without the websocket) in the cffi and then start using it through the nodebindings over electron ipc. then desktop can migrate more and more functions to it until the cmd-api is complete enough to be ready for standalone websocket based experiments.
