core icon indicating copy to clipboard operation
core copied to clipboard

Email addresses with a dot at the end exhibit strange behaviour.

Open Simon-Laux opened this issue 3 years ago • 1 comments

Currently there is a bug in the message parser (https://github.com/deltachat/message-parser/issues/19) that triggers this behavior, but there are also other ways one can get a contact with an address that ends with a single dot (copy paste, typing an extra dot by accident at the end).

So the strange behavior is that it creates a new contact and chat which has the following properties:

  • no avatar ever
  • no encryption
  • messages do arrive at the other end

Question is what we do about it: A. we could ignore the last char of the address if it is a . char B. we could return an error when trying to create a contact with such an address C. Something else? post your ideas below

Simon-Laux avatar Apr 13 '22 12:04 Simon-Laux

I tend towards B. -- question is if/how UIs provide feedback on "wrong" addresses when a user tries "+ new contact" action. Probably "dc_may_be_valid_addr" should be stricter and UIs should only offer the new-contact option if it returns True?

hpk42 avatar Apr 16 '22 15:04 hpk42

Made a fix: #4684

link2xt avatar Sep 05 '23 12:09 link2xt

why is this issue not auto closed with the merged pr? Isn't it solved now?

Septias avatar Sep 06 '23 15:09 Septias

strange maybe because it was merged to stable instead of master, anyway let's manually close it.

Simon-Laux avatar Sep 06 '23 15:09 Simon-Laux

strange maybe because it was merged to stable instead of master, anyway let's manually close it.

Yes, GitHub only closes issues when PRs are merged to default branch: https://github.com/orgs/community/discussions/13240

link2xt avatar Sep 06 '23 16:09 link2xt