Email addresses with a dot at the end exhibit strange behaviour.
Currently there is a bug in the message parser (https://github.com/deltachat/message-parser/issues/19) that triggers this behavior, but there are also other ways one can get a contact with an address that ends with a single dot (copy paste, typing an extra dot by accident at the end).
So the strange behavior is that it creates a new contact and chat which has the following properties:
- no avatar ever
- no encryption
- messages do arrive at the other end
Question is what we do about it:
A. we could ignore the last char of the address if it is a . char
B. we could return an error when trying to create a contact with such an address
C. Something else? post your ideas below
I tend towards B. -- question is if/how UIs provide feedback on "wrong" addresses when a user tries "+ new contact" action. Probably "dc_may_be_valid_addr" should be stricter and UIs should only offer the new-contact option if it returns True?
Made a fix: #4684
why is this issue not auto closed with the merged pr? Isn't it solved now?
strange maybe because it was merged to stable instead of master, anyway let's manually close it.
strange maybe because it was merged to stable instead of master, anyway let's manually close it.
Yes, GitHub only closes issues when PRs are merged to default branch: https://github.com/orgs/community/discussions/13240