core icon indicating copy to clipboard operation
core copied to clipboard

Quoted text in Outlook replies is not recognized correctly

Open yisraeldov opened this issue 4 years ago • 11 comments

  • Operating System: Linux (nixos)

  • Delta Chat Version: Version 1.15.5 (git: v1.15.4-1-g77948e7b)

  • Expected behavior: When receiving a reply from a traditional mail client, delta chat should hide the quoted original message. This works only sometimes.

  • Actual behavior: With mail clients like Outlook, the entire quoted message is shown as normal.

  • Steps to reproduce the problem:

    • Send a message to a traditional mail client (outlook) using delta chat
    • Reply to that message using mail client (outlook)
    • See that the whole message is shown.
  • Screenshots:

    • from outlook.com Selection_007
    • outlook style vs quoted from evolution image
    • same but on android image
  • Logs:

yisraeldov avatar Jun 14 '21 09:06 yisraeldov

Could you post an example of such an email from Outlook? Quote-detection is hard and maybe someone already tried to make it work with Outlook but failed, but maybe we can improve it

Hocuri avatar Jun 14 '21 16:06 Hocuri

What you get from outlook.com is even worse, but I don't have an account to test it. here is a redacted image. Selection_007

image

yisraeldov avatar Jun 14 '21 16:06 yisraeldov

I forgot to say this above, but what we need is the (anonymized) source of the email. There must be a button like "Show full email", "View raw" or similar in your email client. Thanks in advance!

Hocuri avatar Jun 14 '21 17:06 Hocuri

I can only do screen shots from my phone.

From: Hocuri @.> To: deltachat/deltachat-core-rust @.> CC: Yisrael Dov Lebow @.>; Author @.**> *Received: *Jun 14, 2021 20:41:58 *Subject: *Re: [deltachat/deltachat-core-rust] Quoted text in replies is not always hidden correctly. (#2496)

I forgot to say this above, but what we need is the (anonymized) source of the email. There must be a button like "Show full email", "View raw" or similar in your email client. Thanks in advance!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[https://github.com/deltachat/deltachat-core-rust/issues/2496#issuecomment-860868754], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AABBX235YY3HVUD2IZLZDTTTSY5ONANCNFSM46VFCB4Q]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAABHNCSVQICAgIfAhkiAAABH9JREFUaIHtWU1u20YU/p4oFdGqRpbdWN5kW+YEpjeFpUoIcwK7BwhsFzmAD9DGdi5g6QSRYVUsshF1glLLrPyzLVCkKxeRxK8LyrY4w6FGP3YK1B8gQBy+/5l58+YReMLXhTyUYAYNphRVzx9EV+EhhD4mnhz42ljZumSwXQGcTbDgQugC4ikUISgRJI6AcV+qv1+uQu/SDjD4cQcUHyL+fIxsQ9iW6m+tZfQv7ACDugfiCCLuMgaAjCA4kGonXIR9IQfYbRxBsL8Ir1kojqV2fjAv21wOsOev4Z/RB31931EMQDYhEsGJP8sP3QgA+LHmYlxYA+AB8AH53sAf4lnxtWy1P6/cAfb8NdyMeoYl0wKGh7YbM9nwpUMAO/pLRigXt2ydsHcgqPe0yJNXEOwuun4n+6gJkXXlTSjVzpaNDKtzgN36sW48+igX3UWNBwCpdkKUiy6IvvLGS3RayJhFwKDuAdJLD6IvtXPP2lILsNsIIdhURrdmBWj2DBBH6WdeoezMl/NtUHZ8kFe5ujOQOwMMGrsATpXR3Kgw2K6ApT2A3t2GJyNAQsjwJG+jG2b7tdTO2yaeWTOgRrqVa3y3fgyULiDYT2UrETc5N0oX7DaMUZ3ITp/Mgt08A40zMEl1F+nR4YYpggzqkTm/q8SMpNZ5uQq9OTNQ8hTRA6PxSZayMx4ARFxTlkl0cJBvyz3MDpCu8tzMJAu2KxDZU2ivwfgtyJ3kF78FeZ22VPaSaGciveZVW6aQMwPKiSsSZZKxmK6JyGsID+AUPsGRv5Jf4ROEB5oTKu89wlxbplC8k6XcYTU4cfbRLvDSA3yPQuGLRlcofME4fg/IL1Ojmxrdra6xM61j03THtr6R3RZmGW/Sa19wkU0HAPJn+jE7smZdOh73SikyXLVIawf4sWZYh0rGIDbMQuLvcnln6tJxtwfUvo1WmyT1fIY2hBBMLSN5gzj+WdsHcfwNIG803iyounJqr5wZYHodmlKZjNL5XGQdlHeI+QJjPseYzxHzBSjvtLJZ5b2HYiyNe8LsgJY2Rb98YHLwkCcK7zogv0KkBZHW5H/aeNJcFxGv8m2xcQDDUBHimg4eqXX2Tes5GxwkPBlvkoNRmW3FlikYHZhE5yw9Wjo003dcbSYyLeSJVDvmTcqiWuyd5VWws7KQWsbuJCVvNpKoDjcSR6ZnhINkbLhhijwwKafV/hLRzDPQ5kamVpmXeOa8nKdzYIOk4zH+A0DlfnD2zc/mHFAjVklaKyvGzaiHaeMBQHg4i82qK8Fu/VirOBfo4WTKNrVryJO85XYL+7ZK5qUblwB/WqqtAjmFGvk5mgb2tVDZ8TNSZQWQHoPGaU5tr4HBdoXd+ofJ/Vfh42CepsH8rcWbcTtjJiYEjCBogxKiOP471VocOd9C6IHwjQ1hoo+y4z9IazGlJ3NPLAnLNa9iufY6MN9dOFvSAMD+o7bXU+q7DX/S+ng1i1bBGYhmXs/HBiv+xFTykqpVXG2fEH2AUVKYDcP/zCcmE56+E1viyYEn/N/xL1rLBlHOzMGSAAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AABBX22DK5XNIAGU7DLQTNLTSY5ONA5CNFSM46VFCB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNH5BEQ.gif]

yisraeldov avatar Jun 14 '21 18:06 yisraeldov

Just noticed by @gerryfrancis: Please retry with version 1.20. Maybe the bug was fixed in the meantime.

Hocuri avatar Jun 16 '21 14:06 Hocuri

Just noticed by @gerryfrancis: Please retry with version 1.20. Maybe the bug was fixed in the meantime.

I already have the latest version on one of my android devices and the issue still exists

yisraeldov avatar Jun 16 '21 15:06 yisraeldov

the issue still exists

@yisraeldov Does it occur with mails sent from Outlook only?

gerryfrancis avatar Jun 16 '21 15:06 gerryfrancis

I have noticed it when the mails come from "outlook.com" also if I send a mail from evolution and use outlook style quotation it also happens. 

I can't say for sure it only happens with out look.

(BTW if I get messages not in english the quoted message also doesn't show correctly)

On Wed, 2021-06-16 at 08:39 -0700, gerryfrancis wrote:

the issue still exists

@yisraeldov Does it occur with mails sent from Outlook only?

yisraeldov avatar Jun 16 '21 16:06 yisraeldov

Looks like outlook has its own special quoting style: https://superuser.com/questions/204224/how-do-i-enable-internet-style-quoting-in-outlook-web-access

link2xt avatar Jun 17 '21 11:06 link2xt

@link2xt Quoting in OWA (Outlook Web Access) works fine. (I have verified it with the domain user for my Outlook mail account.) When I send a reply from Outlook to my Posteo account configured in Delta Chat, the quote is correctly recognized, I can see "Show full message". I cannot reproduce the issue neither with Outlook 2013 nor with OWA.

if I send a mail from evolution and use outlook style quotation it also happens.

@yisraeldov Could you switch to HTML formatted mail, try again, and report back, please? Thanks in advance.

gerryfrancis avatar Jun 17 '21 12:06 gerryfrancis

"Outlook style" is better illustrated here: https://en.wikipedia.org/wiki/Posting_style#Top-posting

Evolution supports this "Outlook style" which results in original message with a line -----Original Message----- (no spaces between - and the words!) at the top, then headers (From, To, Subject and Date), then a single empty line, then the original message.

Currently these "Outlook style" quotations are removed as non-standard footers, see related issue #2203. They should be parsed as quotes instead, and then parsing of footers can be tweaked.

link2xt avatar Jun 24 '21 04:06 link2xt