chathub icon indicating copy to clipboard operation
chathub copied to clipboard

Fix browser detection logic in navigator.ts

Open khengyun opened this issue 9 months ago • 1 comments

Error:

image

Description:

This PR fixes an issue in the getBrowser function of navigator.ts where the condition 'Edge' || 'Chrome' was always evaluating to 'Edge', causing incorrect browser detection. The updated logic ensures accurate identification of browsers, including Edge and Chrome, by explicitly checking for each browser string separately.

Changes Made:

Updated the getBrowser function:

Replaced the incorrect condition 'Edge' || 'Chrome' with distinct checks for 'Edge' and 'Chrome'. Combined the redundant checks for 'MSIE' and 'Trident' into a single condition for detecting Internet Explorer ('IE').

Code Refactoring:

Improved the logical order of browser checks for better maintainability. Ensured that 'Edge' is checked before 'Chrome' to avoid misidentification.

Added comments for clarity in the browser detection logic.

khengyun avatar Jan 17 '25 07:01 khengyun