electricShine icon indicating copy to clipboard operation
electricShine copied to clipboard

install_user_app() code

Open chasemc opened this issue 5 years ago • 1 comments

Here is where it breaks:

` my_package_name <- electricShine::install_user_app(library_path = library_path , repo_location = "local", repo = local_package_path, repos = cran_like_url, package_install_opts = package_install_opts) }

Transfer icons if present -----------------------------------------------

electron_build_resources <- system.file("extdata", "icon", package = my_package_name, lib.loc = library_path)`

Because electricShine::install_user_app can only return a NULL as it just gives the result of readLines() on a newly created tempfile?

I'm happy to help make this thing a reality, but, the code in install_user_app is really confusing. Like, are all of the environment variables just being used to prevent you from having to pass variables between functions?

Originally posted by @BenWiseman in https://github.com/chasemc/electricShine/issues/368#issuecomment-701624299

chasemc avatar Dec 08 '20 15:12 chasemc

Code needs better documentation.

The variables are the only way to make R install packages in the correct location

chasemc avatar Dec 08 '20 15:12 chasemc