vim-ansible-yaml icon indicating copy to clipboard operation
vim-ansible-yaml copied to clipboard

Published 20 hours ago • verified publisher icon chase

Ansible functions

Open benjifisher opened this issue 10 years ago • 2 comments

This needs thorough testing, but I think it solves #2. The first commit reorganizes parts of the jinja syntax file, but should have no effect at all on the highlighting. The second commit uses the syntax cluster defined in the first commit to get the desired effect, highlighting "foo bar" in when: foo bar the same way it is highlighted in "yaml string {{ foo bar }}".

Note that #26 currently breaks some test cases, so that should probably be resolved before this is considered.

benjifisher avatar Dec 01 '14 05:12 benjifisher

#26 should be resolved by #27, but I'd like you to go over it to see if I missed any parts of the pointless redundancy between yamlScalar and yamlMapping you mentioned before I merge it with master.

chase avatar Dec 01 '14 05:12 chase

I was testing this and noticed that a lot of the syntax highlighting was messed up. Then I realized that the problem was coming from 8050b3f, which we have since reverted.

So I rebased this branch onto master. In part, I was curious to see how GitHub would treat a rebase on a pending PR. Somewhat to my surprise, it updated the PR automatically. As I write this, the two commits were "added" 22 days ago, but "committed" about 15 minutes ago.

I think that this patch works well: it fixes #2 and does not seem to cause any other problems. I would like another pair of eyes on it before I merge.

benjifisher avatar Dec 23 '14 04:12 benjifisher