chartjs-plugin-zoom icon indicating copy to clipboard operation
chartjs-plugin-zoom copied to clipboard

refactor: VuePress to VitePress

Open bavoco opened this issue 1 year ago • 15 comments

This reduces the number of dev dependencies by about 700.

Towards #812

bavoco avatar Mar 11 '24 22:03 bavoco

By nature, the move from VuePress -> VitePress should also allow us to drop the babel dependencies too, right? A very brief peek at the source suggests it is not used outside of VuePress.

NotTsunami avatar Apr 10 '24 16:04 NotTsunami

I tested it on your branch and npm run docs passes with the babel dependencies removed. With @babel/core, @babel/preset-env, and babel-loader removed, another 155 packages are removed. npm run test passes with 76/76 tests while npm run lint and npm run build complete without error.

NotTsunami avatar Apr 10 '24 17:04 NotTsunami

You should be able to remove ng-hammerjs as well, since it was only used in VuePress: https://github.com/chartjs/chartjs-plugin-zoom/blob/bfd207d9108cbcd612b8f4c2b0221ef8e7ed373b/docs/.vuepress/config.js#L89-L90

NotTsunami avatar Apr 10 '24 20:04 NotTsunami

Great! If #808 gets merged there won't be two versions of Rollup and related plugins further reducing the count.

bavoco avatar Apr 11 '24 10:04 bavoco