chartjs-plugin-annotation
chartjs-plugin-annotation copied to clipboard
Enable callout in the label of line annotation
This PR is enabling the callout options in the label of line annotation.
TODO
- [x] test cases
- [x] types
- [x] documentation
- [x] samples
~~@kurkle I have a doubt about CC issue. We could need an object to create and add to element.defaults but where? Maybe a additional file "callout.js", which contains all functions to manage the callout?~~ ~~Maybe this could be applied to the labels and arrowHeads (to reduce the size of the js files and close some CC issues). Just a proposal.~~
EDIT: solved importing LabelAnnotation class.
@kurkle I solved CC duplication code issue using the defaults of the label annotation for callout.
@kurkle I solved CC duplication code issue using the
defaultsof the label annotation forcallout.
I think the common should now work for these shared defaults.
I think the
commonshould now work for these shared defaults.
I wasn't sure. Let me try
@kurkle I solved CC duplication code issue using the
defaultsof the label annotation forcallout.I think the
commonshould now work for these shared defaults.
I have removed the callout options from label ( leaving ONLY the callout node) and adding them in the common, you don't have any fallback. In my opinion, but maybe I'm wrong, when the options are loaded in the element, only defaults and defaultRoutes of the element are used (and not the common).
Therefore to work, we should maintain all callout options and setting to undefined to have the fallback but only to centralize the defaults, not the options.
@LeeLenaleee @kurkle I have marked as ready for review. Nevertheless we should NOT merge it till mid/end of next week, giving at least 2 weeks to version 2.0.0