Chart.js icon indicating copy to clipboard operation
Chart.js copied to clipboard

fix: label arrays to be delimited by comma and add spaces for line charts

Open zenocross opened this issue 6 months ago • 3 comments

Closes https://github.com/chartjs/Chart.js/issues/12049

Line controllers apparently didn't have an overridden implementation for DatasetController's getLabelAndValue method. Kept it within the line controller to not affect anything else.

zenocross avatar Jun 09 '25 21:06 zenocross

I'm not 100% sure that #12049 is a bug. @LeeLenaleee thoughts?

etimberg avatar Jun 10 '25 00:06 etimberg

I agree that it is not visually the most pleasing, but I don't think this is the correct fix. Since we have a multi line label I think the more appropriate fix would be to multi line the title 🤔

LeeLenaleee avatar Jun 10 '25 10:06 LeeLenaleee

@LeeLenaleee Do you mean we'd want to modify the ', ' to an '\n' or is it something else altogether? Also, does the title text need to be centered?

New impl Would be fine for a tooltip with a label with the following label array? ["Blue", ["subTitle", "hehe", ["test", "test2"]]]?

zenocross avatar Jun 10 '25 11:06 zenocross