Chart.js
Chart.js copied to clipboard
chartjs
fix: calc visible points on update
Would it be ok if I made a PR for this into a potential 3.9.2 release? It would help our company to have this fix without waiting for the 4.0.0 release. This issue is on 3.9.1, and I cherry-picked this onto that and it works nicely.
I believe this bug affects other plot controllers too (e.g. ScatterController). Can the same fix be applied to other updateElements(points, start, count, mode) routines?
Can we please have this fix for v3? I can not update to v4 on my current company setup
Is it possible to have this fix on a new release for v3? Our company is stuck because of this issue.
V3 is out of support and won't get any new updates, if you want this update for V3 you can always implement it yourself, build the project and ship it locally.
That's rude. You have a non working v3 version with a lot of track from the community since 2020 and a non working v4 version which almost nobody uses because it was implemented just a week ago. You also already have a fix for an issue at least 10 people across 3 different issues has asked for and yet you just don't release a needy v3 patch? This project has a literal 0 days support-deprecation notice that i missed? Even Ubuntu gives at least 2 years. How can you just go with "we don't care for older stuff, update to the latest" when people are already telling you it is not possible for us to do update?
We are a small team of developers that try our best to maintain chart.js so it is not feasable for us to keep maintaing older versions of the software. So while some users might not be able to update, we dont have the resources to keep older versions maintained.
As I suggested you can implement this fix yourself in the latest V3 state (https://github.com/chartjs/Chart.js/tree/3.9) and bundle it locally with your app
I know you are a small team and i deeply appreciate your work. Believe me, i have been using ChartJS since v2 from 5 years ago and i do not plan on stopping using it anytime soon.
What i do not understand is that @jonasem has already given a working fix for this issue which has been developed and approved on v3 but for some reason the team has decided to not launch it on a last v3 version but directly on v4, even more when there are several people telling that it is needed for v3 because we depend on it. It also buffles me that the fix was provided almost 2 months ago and v4 was release just 1 week ago. What about all the issues that has been solved in this 2 months?
I'll try to get a v4 version working but stuff like this should at least be advertised on the Changelog for the release, because this is not just a breaking change or a new quirk, it is directly non-implementation of fixes provided by the community that can be found online and lead to lost hours of development like i've suffered thinking i was doing something wrong when the issue was from within the library.
Sorry for the rant, it's been a long day.