Chart.js icon indicating copy to clipboard operation
Chart.js copied to clipboard

Start moving lecacy scale hooks to plugin

Open LeeLenaleee opened this issue 1 year ago • 6 comments

Resolves #10155

TODO:

  • [ ] Fix Failing test
  • [ ] Write migration
  • [ ] Update docs https://www.chartjs.org/docs/latest/axes/#callbacks
  • [ ] Update typings

@etimberg you added the breaking change to it but in its current form its not breaking right since it still calls the hooks like it used to or do you want to have the call (line 527) here also removed?

https://github.com/chartjs/Chart.js/blob/f957aad352a39d4916b6cde3260009dee6ec74a4/src/core/core.scale.js#L525-L528

LeeLenaleee avatar Aug 25 '22 23:08 LeeLenaleee

Yeah, I had thought we could remove line 527 so that it only goes to plugins and avoids these option callbacks

etimberg avatar Aug 26 '22 01:08 etimberg

@LeeLenaleee @kurkle do we still want this in v4? It's the last thing

etimberg avatar Oct 01 '22 20:10 etimberg

Every time I look at the test i can't seem to make them work so stopped looking at it, will give it another look Monday evening see if a fresh look sees what I did wrong and otherwise we can either skip it or someone else has to fix the test

LeeLenaleee avatar Oct 01 '22 21:10 LeeLenaleee

I'm thinking we should skip this and move it to v5 at this point. Thoughts @LeeLenaleee @kurkle @dangreen ?

etimberg avatar Oct 10 '22 20:10 etimberg

Agree

LeeLenaleee avatar Oct 10 '22 20:10 LeeLenaleee

Agree

dangreen avatar Oct 10 '22 20:10 dangreen