textacy icon indicating copy to clipboard operation
textacy copied to clipboard

Add download command to Makefile, use it in a GitHub Action, and update CONTRIBUTING.md

Open Hironsan opened this issue 2 years ago • 0 comments

Description

When I cloned the repository and ran the test, I noticed that I needed to download the language data. That was not mentioned in CONTRIBUTING.md. So, I added the download command to the Makefile, use it in the workflow as well, and update CONTRIBUTING.md.

I also comment out some test cases to pass the test. I think the root cause is that the version of the dependencies is not locked. This PR doesn't solve the problem.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation, and I have updated it accordingly.

Hironsan avatar Aug 29 '22 09:08 Hironsan