textacy icon indicating copy to clipboard operation
textacy copied to clipboard

most_discriminating_terms no longer available

Open quillan86 opened this issue 2 years ago • 2 comments

steps to reproduce

I've previously used most_discriminating_terms function before but it seems to be commented out. It's necessary for my current role so far because I have a series of documents labeleld with a certain theme relative to a larger series of comments and I want to see what are the most discriminating terms in that document, but it seems like the code has been commented out.

expected vs. actual behavior

Tried importing textacy.extract.utils.most_discriminating_terms - not availble - code seems to be commented out

possible solution?

Reinclude this function

context

See above

environment

  • operating system: macOS
  • python version: 3.9
  • spacy version: 3.3.1
  • textacy version: 0.11.1

quillan86 avatar Jul 01 '22 11:07 quillan86

Hi @quillan86 , I removed — well, "hid" — that function a while ago because I could no longer vouch for or maintain it. I'm interested in reintroducing the functionality, in some form, back into textacy, but I haven't had much bandwidth for non-trivial to-dos. Just checking: Is this something you'd be comfortable hacking on? If not, you're totally welcome to copy-paste the code and make use of it internally as you see fit until I'm able to work on a suitable successor.

bdewilde avatar Jul 25 '22 23:07 bdewilde

Hey @bdewilde, Kindly let me know if I can work on this

KalyanKumarPichuka avatar Dec 09 '22 04:12 KalyanKumarPichuka