Charles Harris

Results 283 comments of Charles Harris

Doctests are failing badly.

Thanks @DimitriPapadopoulos .

It would be helpful to document how this apparatus is intended to operate. Maybe with some diagrams with arrows tracing a call.

I have a somewhat different concept as to how this should be handled. I would just add two slots that take function dispatchers that get passed the context and return...

Needs rebase. Again, leave distutils alone, not only is it not maintained, it is fragile.

I would not worry too much about the lint failures, but it would be good to fix them in another pr.

Generally looks good to me. There are ~two~ three things that might need some discussion. - Replacing pycodestyle by ruff. I'm not opposed, and ruff seems actively maintained. Is there...